Repository navigation
fix(release): align extensions, chat, presentation, and transport tests for v2.4.0 - #9156
Conversation
…ts for v2.4.0 Signed-off-by: LoopX Agent <[email protected]>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent | model: Gemini | provider: Google | declaration_source: self_reported
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
动机 / Motivation
在 v2.4.0 发布前稳定化验证中,受影响的调用方包括:使用带租约嵌套托管 CLI(delegated_cli)的协作执行与停止编排、通过浏览器或 Chat 入口分页读取关联原始 Goal 历史与发现(explore-results)的操作者、运行在非 UTF-8 系统默认代码页(如 cp936/gbk)上的升级/PR 证据/远程网关/Lark CLI 子进程调用方,以及依赖统一激活 schema、结算进度字段和工作树隔离契约的本地验证套件。
修改前:当嵌套托管子进程已上报 spawned 后因外层停止而抛出异常时,host_process_transport.py 无条件进入 _cancel_guarded_host,对已暂停的内层 supervisor 发送 SIGCONT 并中断等待,导致嵌套 Host 被提前唤醒清理并破坏租约停止时序;同时 goal_source._read_page 在分页中途缓存失效时抛出 SourceScopeError,被 explore_results_api 误映射为 404(目标不存在)而非 409(读取中途快照失效);此外 5 处文本/子进程调用未显式固定 UTF-8 编码,且 16 个测试文件仍沿用已退役的 activation_state 字段、旧 BASE_REVISION 或高并发下过紧的超时阈值。修改后:仅 supervision == 'direct' 在 spawned 之后走 _cancel_guarded_host,leased 路径改走 stdin EOF 排空与超时清理;goal_source._read_page 在缓存失效时抛出 ValueError,使 explore_results_api 准确返回 409 且缺失作用域仍保留 404;5 处文本/子进程调用全部显式绑定 encoding='utf-8',16 个测试文件与当前生产契约及并发超时预算对齐。
23 个变更文件对应的 7 项生产修复与 16 项测试契约对齐全部恢复稳定:嵌套 Host 停止测试不再因误发 SIGCONT 破坏已暂停 supervisor 证据,关联来源分页失效准确返回 409 而非 404,仓库级 UTF-8 静态守护清零(基线 5 处违规降为 0),独立复测的 22 个核心测试文件 596/596 通过、9 个邻接回归测试文件 221/221 通过(5 个平台条件跳过)、ruff/mypy/RFC 双语/公开边界扫描及 canary premerge(18/18 检查)全部通过。
本 PR 不改动并行推进中的配额或 Turn 决策路径,也不处理依赖 execution_preparation.py 并行修复的 test_delegation_lease_lifetime.py、test_independent_delegation_validation.py 与 test_native_steward_reports.py。
说明:本 PR 属于 v2.4.0 发布前跨模块回归稳定化切片,没有单独的 RFC 或单一功能规格文档;上述结论基于既有代码契约、HTTP/进程监督边界及独立实测验证。
改动思路 / Approach
每项生产改动都收敛在各自原有的决策或 IO 边界内(host_process_transport.run_host_process 的 supervision 分流、goal_source._read_page 的异常语义区分、以及 5 处现有子进程/fdopen 调用的编码参数补全),未引入新模块、新配置开关、新状态字段或兼容性旁路;16 个测试文件也仅更新已退役 schema 字段、新增环境变量与并发容忍阈值,未削弱任何产品断言。
当前 PR 边界严格限定于 v2.4.0 发布前不涉及并行配额/Turn 决策重构的 7 个运行时边界修复与 16 个测试文件对齐,将依赖 execution_preparation.py 的 3 个 RefreshTaskLeaseUnavailable 租约测试明确留在外部并行切片中处理。
| 改动面 | 原问题 | 修复/对齐方式 | 所属边界与回滚特性 |
|---|---|---|---|
| 嵌套 Host 取消 | spawned 后异常误走 _cancel_guarded_host 并发送 SIGCONT |
仅 supervision == "direct" 在 spawned 后走 _cancel_guarded_host,leased 走 EOF 排空 |
host_process_transport.py 单点条件收窄,可独立回退 |
| 来源分页失效映射 | _read_page 抛出 SourceScopeError 导致 404 误报 |
中途快照失效改抛 ValueError,explore_results_api 映射 409,runtime_workspace 映射 503 |
goal_source.py 单行异常类型修正,缺失 scope 仍抛 SourceScopeError (404) |
| UTF-8 编码显式绑定 | 5 处 subprocess / os.fdopen 依赖宿主默认编码 |
显式传入 encoding="utf-8" |
消除跨区域/Windows cp936 解码风险,基线 5 处违规清零 |
| 测试与并发阈值对齐 | 16 个测试使用已退役 activation_state、旧基准 commit、缺省字段或过紧超时期限 |
改用 build_goal_activation、settlement_progress、LOOPX_TURN_KEY、新 BASE_REVISION 及 1.5s/15s 超时 |
黄金输出与核心安全断言完整保留 |
具体改动 / Changes
本 PR 未引用独立 RFC(spec_basis: no_spec,无成对 RFC 文本修改),所有改动对照仓库既有运行时与测试契约核验,具体覆盖 7 个运行时文件与 16 个测试文件(共 23 个文件,+170/-58 行)。
关键代码讲解
-
run_host_process(loopx/control_plane/turn_driver/host_process_transport.py:425-434):
在finally清理分支中,将触发_cancel_guarded_host的条件从(launch_deadline is not None or sys.exc_info()[0] is not None)收窄为(launch_deadline is not None or (supervision == "direct" and sys.exc_info()[0] is not None))。在spawned之前(launch_deadline is not None),无论是direct还是leased仍必须执行_cancel_guarded_host以守住启动围栏;而在spawned之后(launch_deadline is None),直接执行路径(如codex_cli的check_running中断)继续走_cancel_guarded_host(保留require_host_return与暂停桥接的SIGCONT唤醒语义),而嵌套租约路径(delegated_cli通过LOOPX_HOST_PROCESS_PARENT="leased"标记)进入else分支,只关闭proc.stdin触发 EOF 排空并在超时后仅proc.kill()桥接进程,不再向被测试或异常暂停的嵌套 supervisor 误发SIGCONT。 -
GoalSourceReader._read_page(loopx/control_plane/status/goal_source.py:387-389):
当分页加载期间self._pages被并发刷新或失效替换(pages is not self._pages)时,改为抛出ValueError("The original Goal source became unavailable during the read")而非其子类SourceScopeError。核查explore_results_api.py:208-215可确认:SourceScopeError仍保留给check_scope、check_access、registered_status等真正缺失 Goal/作用域的场景并返回 HTTP 404,而中途快照失效落入except ValueError分支并返回 HTTP 409(runtime_workspace.py:219-225则返回 503 提示刷新重试),不再把并发失效误报为 404。 -
UTF-8 编码显式绑定(5 处生产文件):
分别在loopx/capabilities/native_chat/github_pr_evidence.py:117(git config --get remote.origin.url)、loopx/cli_commands/support_control_upgrade.py:222(原生桌面升级准备子进程)、loopx/control_plane/coordination/remote_authority_gateway.py:69(Node 远程权威探测桥接)、loopx/extensions/lark/cli_resolution.py:281(带dispatch_guard的subprocess.Popen)以及loopx/self_update.py:1515(.install-guard文件描述符os.fdopen(..., "r+", encoding="utf-8"))补齐encoding="utf-8"。在基线3144369890eb4be55e0f0c0275825c163c9d8a0c上运行test_loopx_text_io_utf8与test_runtime_subprocess_utf8的检查器可精确复现这 5 处违规,而在 headce6687d357e09e87bb4dac2c13ca335397c9d227上全部清零。 -
test_production_cli_archive_parity(tests/test_global_todo_readiness_characterization.py:17):
仅将BASE_REVISION从d4aaaaefbd37a83a30f10681de839b45d631eeb9更新为包含存储兼容修复(#8902)的祖先提交d210e4cc1d002f92498b2811c565b9430e79f4c1;tests/fixtures/global_todo_readiness.json及test_complete_outputs_and_crossings的全部黄金字节/调用次数断言保持原样,且真实file/sqlite双后端归档 CLI 对等测试通过。 -
契约与并发稳定性测试更新(其余 15 个测试文件):
tests/extensions/test_periodic_report_goal_channel_delivery.py、tests/test_chat_operation_actions.py、tests/test_manager_context_handoff.py、tests/test_zcode_goal_bridge.py:将已淘汰的activation_state = "stopped"/"active"改为标准build_goal_activation(...)(loopx_goal_activation_v1),同时test_manager_context_handoff.py仍保留非法state: "invalid"的拒绝测试。tests/presentation/test_background_services_api.py、tests/test_chat_status_owner.py、tests/test_kunluncode_goal_mode.py、tests/test_lark_native_reply_context.py、tests/test_native_steward_turn_host.py、tests/test_task_lease_worktree.py、tests/test_turn_machine_credential.py:分别补齐空registry.json初始化、切换至规范模块loopx.chat.todo_source、在 mockcapture()中补全settlement_progress(quota_settlement_progress_v0)、将test_unquoted_provider_root_keeps_plain_input_and_no_parent_read的api断言收敛为精确的单条当前消息无损读取(同时保持零父消息/历史读取和 1 次+messages-mget)、将managed_turnhook 从start_turn对齐到真实调用入口CodexAppServerAdapter.start_native_task_turn、将当前虚拟环境可执行目录前置到PATH、以及在期望环境中补全LOOPX_TURN_KEY。tests/test_contract_git_probe_budget.py、tests/test_doctor_git_probe_budget.py、tests/test_lark_event_collector_git_budget.py、tests/test_lark_private_ingress.py:在保留全部子进程树清理验证与消息投递不变量的前提下,将高分片并发下的测试超时分别放宽至1.5s和15s。
对主干的风险 / Risks
- 阻断性发现:无阻断性缺陷(no blocking finding)。
- 残留风险与边界说明:
host_process_transport.py在supervision == "leased"且已spawned后遇到异常时不再调用_cancel_guarded_host(..., require_host_return=...);若未来出现嵌套delegated_cli内部同时以interrupt_before_terminate=True运行并由check_running()触发中断的场景,会通过 EOF 排空路径停止进程组且record["phase"]保持"spawned"(execution_host_drain仍会检查进程组存活而不误判为已排空),但不会额外写入interrupt_unconfirmed标记。当前test_delegation_stop_nested_host.py、test_host_launch_authority.py与test_turn_interruption_recovery.py均验证行为正确。loopx/extensions/lark/cli_resolution.py:293在dispatch_guard is None分支调用注入的subprocess_run(...)时未显式传encoding="utf-8"(不同于第 281 行的subprocess.Popen),当前test_runtime_subprocess_utf8.py仅扫描subprocess.run/Popen/check_output且生产调用方另有封装,风险极低,可在后续清理中评估是否统一。- 独立复测在隔离的
HOME/TMPDIR/--basetemp下执行,仅在本地工作树存在临时node_modules软链接以支持 TS 相关测试与词汇扫描;全部 23 个变更文件已核验无绝对本地路径或私有状态泄露。
我的整体评价 / Verdict
- 长程与用户体验影响(
outcome_impact):long_horizon为improved(消除了嵌套租约停止误唤醒与关联来源分页并发误报,恢复跨区域 UTF-8 升级/网关子进程稳定性);user_experience为improved(浏览器分页失效从误导性 404 恢复为准确的 409/503 重试语义),且visual_review为not_applicable(本次未修改任何前端页面、HTML 或视觉布局,仅核验goal_source.py与explore_results_api.py的 HTTP 状态返回;unverified_scope为none)。 - 可观测语义与兼容评估:基线与精确 head
ce6687d357e09e87bb4dac2c13ca335397c9d227的对比实测表明,5 处 UTF-8 缺失全部由基线失败转为 head 通过,且test_global_todo_readiness_characterization.py的黄金输出字节与调用次数全量保留;compatibility_assessment为retain(保留supervision == "direct"与SourceScopeError404 既有语义)。 - 代码体量与比例性:全 PR 共 +170/-58 行(7 个运行时文件合计仅 +10/-6 行),
code_volume为necessary,change_proportionality为proportionate(architecture_assessment: retain)。 - 语义对齐:
semantic_alignment为not_applicable(未新增、扩展或重命名任何公开枚举/Schema 词汇,semantic-vocabulary-drift-smoke.py通过)。 - 本地独立验证汇总(均在
ce6687d357e09e87bb4dac2c13ca335397c9d227上执行,不依赖远端 CI):- 核心 22 个相关测试文件:
596 passed, 0 failed, 0 skipped(PASS) - 邻接 9 个回归测试文件(
test_host_process、test_leased_host_process、test_goal_source、test_runtime_workspace、test_lark_cli_resolution、test_self_upgrade、test_update_operation、test_self_update_download、test_self_update_runtime_activation):221 passed, 5 skipped (platform-specific), 0 failed(PASS) ruff check(23 个变更文件):PASSmypy(pyproject.toml17 个严格类型文件):PASSscripts/check_rfc_bilingual.py --base origin/main --head HEAD:PASSloopx check --scan-path(23 个变更文件):PASS(0 errors)loopx canary premerge --from-git-diff --git-diff-base origin/main:4/4direct_checks、1/1py_compile、10/10catalog_canaries、8/8risk_profile_smokes全部 PASS(注:独立检出路径的_repo_key哈希与原 Goal 工作树 CQR 收据cqr_cd5f2f4bbcce0ba2fa8c不同,已独立核对原收据scope_fingerprint与base_commit/head_commit完全一致且有效)。
- 核心 22 个相关测试文件:
English verdict: APPROVE exact head ce6687d; all 7 runtime fixes preserve existing invariants across 817 passing local tests (596 core + 221 adjacent, 5 platform skips), static checks, and premerge smokes with zero blocking findings.
* fix(cli): preserve typed runtime diagnostics in Turn failures Signed-off-by: LoopX Agent <[email protected]> * feat(steward): support per-endpoint model preferences and Codex-to-Antigravity failover (#9141) Signed-off-by: LoopX Agent <[email protected]> * Keep the prepared Chat adapter available to a retry (#9134) A failed worker start can finish cleanup after a same-turn retry has selected the adapter. Keep its lifetime tied to the Session and let failed dispatch release its own worker registration. The regression asserts one upstream turn and explicit adapter closure with the Session. Port the fix from 4453e4bdd77486ec14b952f88ca893310b32e26c. (cherry picked from commit 173e42b4f051b885c3a3389e1cad9c5722f7b7dd) Signed-off-by: LoopX Agent <[email protected]> * fix(steward): recover zero-effect monitors and cleared-replan reports (#9143) Signed-off-by: LoopX Agent <[email protected]> * fix(steward): admit flexible_primary_available executor transitions in conversation_scope (#9145) Signed-off-by: LoopX Agent <[email protected]> * Verify quota gate scope through signed lane references (#9101) * test(quota): verify scoped gates through complete lane references Signed-off-by: LoopX Agent <[email protected]> * Test canonical quota gates in both public response modes Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * Test C1 planning and Host input from the original quota capture (#9102) * Use recorded quota decisions in the no-Todo settlement regression Signed-off-by: LoopX Agent <[email protected]> * Exercise the complete Host prompt from the captured quota source Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * Prepare the CLI budget baseline with a private Git index (#9103) Signed-off-by: LoopX Agent <[email protected]> * Exercise C1 Goal delivery and bound replan from the saved source (#9104) Signed-off-by: LoopX Agent <[email protected]> * Keep long claim overlap scopes on demand (#9086) * Link long thin-claim overlap lists to their receipts Signed-off-by: LoopX Agent <[email protected]> * Read claim overlap details without copying the lease Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(quota): preserve explicit Monitor Todo selection (#9099) Carry Todo selection provenance into quota admission. Preserve explicit secondary Monitor polling and recovery from previously admitted receipts. Signed-off-by: LoopX Agent <[email protected]> * Keep ready Todo scope details on the required context read (#9106) Signed-off-by: LoopX Agent <[email protected]> * Fix archive rollback with custom install directories (#9066) * refactor(core): defer benchmark implementations during capability discovery Preserve the benchmark toolkit public exports and static types while keeping execution and experiment implementations out of metadata discovery. Qualify source and installed Core paths, and reconcile the paired minimal/Standard RFC boundary without changing activation or authority defaults. Signed-off-by: cicolord <[email protected]> * Defer Yardstick evaluation until an enabled Explore read Signed-off-by: cicolord <[email protected]> * Omit empty Todo summary lanes from ordinary Worker context Signed-off-by: cicolord <[email protected]> * fix(update): honor configured archive directories during rollback Signed-off-by: LoopX Agent <[email protected]> * fix(lark): replay recall guard on current main Signed-off-by: huangruiteng <[email protected]> * docs: record the verified LoopX 2.3.0 release baseline Signed-off-by: LoopX Agent <[email protected]> * Preserve quota spend source when prepared work is admitted Signed-off-by: LoopX Agent <[email protected]> * test(quota): qualify native saved complete-Turn checkpoints Signed-off-by: LoopX Agent <[email protected]> * Retry cleanup of an owned file mutation marker Signed-off-by: LoopX Agent <[email protected]> * Keep synthetic Git-path test data outside the public source scan Signed-off-by: LoopX Agent <[email protected]> * fix(quota): share native preparation wait with readiness Signed-off-by: LoopX Agent <[email protected]> * fix(doctor): bind package update readback to its Python environment Signed-off-by: LoopX Agent <[email protected]> * Keep Doctor discovery separate from service activation Signed-off-by: LoopX Agent <[email protected]> * Verify the recorded Python launcher before Doctor probes it Signed-off-by: LoopX Agent <[email protected]> * fix(desktop): require runtime qualification for macOS preview updates Signed-off-by: LoopX Agent <[email protected]> * fix(quota): reuse replan projection owners during recovery Signed-off-by: LoopX Agent <[email protected]> * Qualify Codex 0.169 native context replay on main Signed-off-by: LoopX Agent <[email protected]> * Stop regenerating retired quota view aliases Signed-off-by: LoopX Agent <[email protected]> * fix: pin deferred native context reads to the original capture Signed-off-by: LoopX Agent <[email protected]> * Keep native capture navigation within small output budgets Signed-off-by: LoopX Agent <[email protected]> * Retire legacy heartbeat work prompt generation Signed-off-by: LoopX Agent <[email protected]> * Capture C1 composition failures as receipt diagnostics Signed-off-by: LoopX Agent <[email protected]> * Recover interrupted native Todo readiness from the original Turn Signed-off-by: LoopX Agent <[email protected]> * Revalidate the original lease before publishing resumed native context Signed-off-by: LoopX Agent <[email protected]> * Fence native readiness publication with the canonical lease writer Signed-off-by: LoopX Agent <[email protected]> * fix(scheduler): keep Codex fallback on the original C1 runtime Signed-off-by: LoopX Agent <[email protected]> * fix(scheduler): pin the originating fallback launchers Signed-off-by: LoopX Agent <[email protected]> * Retire the duplicate Codex App scheduler projection Signed-off-by: LoopX Agent <[email protected]> * Seed the recorded scheduler profile in the elapsed-backoff fixture Signed-off-by: LoopX Agent <[email protected]> * Verify canonical cadence on refused and settled Turns Signed-off-by: LoopX Agent <[email protected]> * Pin named Core commands in saved scheduler fallbacks Signed-off-by: LoopX Agent <[email protected]> * fix(research): preserve saved case addresses when a version cannot open Signed-off-by: LoopX Agent <[email protected]> * Preserve citation focus after a saved study refresh Signed-off-by: LoopX Agent <[email protected]> * Capture authenticated LoopX receipts for Research attention (#8790) * feat(research): capture authenticated LoopX attention receipts Signed-off-by: lusendong.6789 <[email protected]> Co-authored-by: TRAE CLI <[email protected]> * fix(research): tighten attention receipt provenance Signed-off-by: lusendong.6789 <[email protected]> Co-authored-by: TRAE CLI <[email protected]> * fix(research): publish attention captures after source validation Signed-off-by: huangruiteng <[email protected]> --------- Signed-off-by: lusendong.6789 <[email protected]> Signed-off-by: huangruiteng <[email protected]> Co-authored-by: TRAE CLI <[email protected]> Co-authored-by: huangruiteng <[email protected]> * Recover the original Session and Turn from a confirmed Chat task Signed-off-by: huangruiteng <[email protected]> * perf(lark,native_chat): eliminate redundant full-directory JSON reparsing in steward chat loops (#9041) * perf(lark,native_chat): avoid full directory reparsing in steward chat loops - Make LarkOwnerAttention._route iterate capture candidates lazily so matching stops at the newest valid p2p capture. - Reuse FileChatDiscovery in PrivateIngressObserver._records while preserving strict field validation and fail-closed errors. - Reuse FileChatDiscovery in ChatExternalConversations.pending so unchanged request journals skip redundant JSON reads and stay mutation-isolated. - Add regression and scan-efficiency tests in tests/test_lark_steward_directory_scan_perf.py. Signed-off-by: LoopX Agent <[email protected]> * fix(native-chat): project small recovery metadata fields to stop data_url memory growth Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * Retire transitional smoke checks and duplicate execution (#9073) Signed-off-by: lusendong.6789 <[email protected]> Co-authored-by: TRAE CLI <[email protected]> * feat(steward): support probe-gated generic continuous_monitor todos with handoff and user actions (#9074) Signed-off-by: LoopX Agent <[email protected]> * Remove redundant defensive prose from prompts and comments (#9072) Remove redundant defensive prose while preserving published heartbeat wrappers and externally managed skill readiness. Validated with 197 related tests, independent historical wrapper migrations and negative cases, installed-skill readback, and current-main quick canary. Existing CI qualification and infrastructure limitations remain recorded in PR #9072. Signed-off-by: lusendong.6789 <[email protected]> Signed-off-by: Lusen Dong <[email protected]> * Keep original Chat retry errors visible during receipt refresh Signed-off-by: LoopX Agent <[email protected]> * fix(steward): tolerate report validator python drift and allow cancel of mid-turn failed reports (#9077) Signed-off-by: LoopX Agent <[email protected]> * feat(steward): add exact-head PR review signals and protected merge confirmation (#9081) Signed-off-by: LoopX Agent <[email protected]> * feat(steward): add isolated OpenViking long-term memory with per-speaker boundaries (#9083) Signed-off-by: LoopX Agent <[email protected]> * refactor(content-ops): slim surface module and eliminate Any (#8961) * refactor(content-ops): slim surface module and eliminate Any Signed-off-by: LoopX Agent <[email protected]> * fix(content-ops): reject malformed angle source_item_ids containers Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(collaboration): batch handoff query Goal lifetime guard lock per Goal (#9085) Signed-off-by: LoopX Agent <[email protected]> * fix(hosts): raise managed service startup readiness timeout to 45s (#9087) Signed-off-by: LoopX Agent <[email protected]> * perf(manager-context): memoize history_inspect lifecycle checks and scope runtime revision in handoffs query (#9088) Eliminate the remaining O(N) Effect runtime RPCs and uncached runtime fingerprinting inside tracking.query(): enter effect_runtime_request_scope() for the query, memoize pure history_inspect lifecycle decisions across entries sharing identical Goal refs while holding the Goal lifetime guard, lazily discover legacy ingress files only when external audience recovery needs them, and preserve entry scan order across Goal batches. Signed-off-by: LoopX Agent <[email protected]> * refactor(lark): slim private_conversations below 2000 lines with net LOC reduction (#8929) Signed-off-by: LoopX Agent <[email protected]> * perf(chat,hosts): skip frontend source re-hashing on immutable installed releases and extend readiness timeout to 90s (#9089) Signed-off-by: LoopX Agent <[email protected]> * refactor(control-plane): split and slim quota monitor_poll_commit (#8885) * refactor(control-plane): split and slim quota monitor_poll_commit Signed-off-by: LoopX Agent <[email protected]> * fix(control-plane): preserve legacy lane budget and observation diagnostic order Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * refactor(quota): slim loopx/quota.py and tighten Any count to zero (#8939) Signed-off-by: LoopX Agent <[email protected]> * refactor(native-chat): slim external_conversations below 2k lines and retire ceiling (#8911) * refactor(native-chat): move steward commission mixin to steward_commands and retire external_conversations ceiling Signed-off-by: LoopX Agent <[email protected]> * fix(native-chat): respect include_raw_response in retained result recovery Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * refactor(chat): slim chat_runtime below 1,500 lines, fix entry-point project_contexts guard, and retire ceiling (#8920) * refactor(chat): move session lifecycle mixin to session_open, deduplicate runtime helpers, and retire ceiling Signed-off-by: LoopX Agent <[email protected]> * fix(chat): drop turn_done_events slot before waking waiters on Thread.start failure Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(steward): paginate open PR signal GraphQL, allow signal-unavailable monitor recovery, and cache private delivery scans (#9093) Signed-off-by: LoopX Agent <[email protected]> * perf(lark,native_chat): back off noop recovery retries and cache recovery lookups (#9096) Signed-off-by: LoopX Agent <[email protected]> * perf(native_chat,lark): cache unchanged quota backlog health and interrupt observations (#9098) Signed-off-by: LoopX Agent <[email protected]> * perf(lark,native_chat): coalesce listener snapshots and cache recovery event summaries (#9100) Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: cicolord <[email protected]> Signed-off-by: LoopX Agent <[email protected]> Signed-off-by: huangruiteng <[email protected]> Signed-off-by: lusendong.6789 <[email protected]> Signed-off-by: Lusen Dong <[email protected]> Co-authored-by: cicolord <[email protected]> Co-authored-by: huangruiteng <[email protected]> Co-authored-by: Lusen Dong <[email protected]> Co-authored-by: TRAE CLI <[email protected]> * refactor(issue-fix): consolidate maintainer-correction admission and slim pr_lifecycle (#8897) Signed-off-by: LoopX Agent <[email protected]> * Fix truncated requests and responses in the Codex API relay (#8713) * fix(codex relay): fence incomplete model requests before drain Signed-off-by: LoopX Agent <[email protected]> * fix(codex relay): surface incomplete upstream responses Port the verified response framing fix to the request-admission branch. Original candidate 27bc3aee311cdfc6a00466ff9d3b58c7db36e01b. Signed-off-by: LoopX Agent <[email protected]> * Bound Codex relay writes to clients that stop reading Signed-off-by: LoopX Agent <[email protected]> * Reject upstream chunked responses missing the trailer terminator Signed-off-by: LoopX Agent <[email protected]> * Validate upstream chunk data delimiters before relay completion Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(release): repair dsh closeout test, antigravity failover alias, and release download retry (#9147) Signed-off-by: LoopX Agent <[email protected]> * docs(release): update v2.4.0 release notes and dsh-loopx-plugin 0.1.1-beta.7 README (#9149) Signed-off-by: LoopX Agent <[email protected]> * fix(chat): recover saved answers and diagnose lost workers (#9120) * fix(chat): recover saved answers and diagnose lost workers Signed-off-by: LoopX Agent <[email protected]> * style(lark): keep private_conversations within module line budget Signed-off-by: LoopX Agent <[email protected]> * fix(chat): retain execution_worker_exited in pending backlog count Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(chat): resume steward requests lost before dispatch (#9125) Signed-off-by: LoopX Agent <[email protected]> * fix(benchmark): restore frozen v1 archives and align checkpoint/runtime tests with C1 defaults (#9151) Signed-off-by: LoopX Agent <[email protected]> * fix(release): stabilize CLI help, architecture guards, onboarding gate, and public smokes (#9152) Signed-off-by: LoopX Agent <[email protected]> * fix(steward): recover report selection across python upgrades and prevent queue kill on observation monitors (#9155) Signed-off-by: LoopX Agent <[email protected]> * fix(release): align extensions, chat, presentation, and transport tests for v2.4.0 (#9156) Signed-off-by: LoopX Agent <[email protected]> * fix(control-plane): stabilize v2.4.0 quota, turn-envelope, and capabilities slice (Slice B1) (#9154) * fix(control-plane): stabilize v2.4.0 quota, turn-envelope, and capabilities slice Signed-off-by: LoopX Agent <[email protected]> * fix(quota): preserve tokenless identity and exact numeric types in attach_complete_turn_context Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(steward): recover frozen report contract failures and rebind resumed task leases (#9157) Signed-off-by: LoopX Agent <[email protected]> * fix(steward): recover pre-dispatch runtime failures across endpoints and stop receipt-unknown disk churn (#9159) Signed-off-by: LoopX Agent <[email protected]> * fix(control_plane): align lease recovery, settlement readback, and runtime fixtures (#9158) * fix(control_plane): align lease recovery, settlement readback, and runtime fixtures Signed-off-by: LoopX Agent <[email protected]> * fix(control_plane): forward record_capture in worker outage test and harden version type guard Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(control-plane): stabilize v2.4.0 explore, context, and checkpoint tail slice (Slice B4) (#9161) Signed-off-by: LoopX Agent <[email protected]> * fix(control-plane): stabilize v2.4.0 replan, monitor recovery, and staged-read slice (Slice B5) (#9160) Signed-off-by: LoopX Agent <[email protected]> * docs(release): reconcile final v2.4.0 stabilization PRs and boundary wording (#9162) * docs(release): reconcile final v2.4.0 stabilization PRs and boundary wording Signed-off-by: LoopX Agent <[email protected]> * docs(release): align #9158 and #9161 descriptions with verified commits Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(steward): tolerate minor JSON delimiter glitches and recover saved report candidates (#9164) Signed-off-by: LoopX Agent <[email protected]> * fix(control-plane): preserve bound yardstick reversals in native replan openings (#9165) Signed-off-by: LoopX Agent <[email protected]> * fix(native-chat): recover loopback relay 401 failures and isolate test auth (#9167) Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> Signed-off-by: cicolord <[email protected]> Signed-off-by: huangruiteng <[email protected]> Signed-off-by: lusendong.6789 <[email protected]> Signed-off-by: Lusen Dong <[email protected]> Co-authored-by: cicolord <[email protected]> Co-authored-by: huangruiteng <[email protected]> Co-authored-by: Lusen Dong <[email protected]> Co-authored-by: TRAE CLI <[email protected]>
Summary
Release
v2.4.0stabilization slice covering extensions, presentation read/API behavior, nested host transport cancellation, UTF-8 runtime hygiene, and test-contract alignment without touching parallel quota/turn-decision surfaces.Delivery Brief
SIGCONTsent to paused nested supervisor after"spawned"), mid-read Goal source unavailability mapping (SourceScopeError-> 404 instead of 409ValueError), unpinned UTF-8 text/subprocess calls, and 16 test files asserting retired fixtures/contracts or tight contention timeouts.627tests passing across 24 targeted files, plus passingruff,mypy, bilingual RFC check, public-boundary check, Goal CQR, and Goal-boundcanary premerge).tests/test_delegation_lease_lifetime.py,tests/test_independent_delegation_validation.py, andtests/test_native_steward_reports.pyuntouched because their remainingRefreshTaskLeaseUnavailablefailure depends on parallelexecution_preparation.pychanges handled separately.Changes
Production Runtime Fixes (
7files)loopx/control_plane/turn_driver/host_process_transport.py: restrict post-spawn_cancel_guarded_hostcleanup (launch_deadline is None) tosupervision == "direct"so leased nesteddelegated_clihosts take the EOF drain branch instead of receiving prematureSIGCONT.loopx/control_plane/status/goal_source.py: raiseValueError("The original Goal source became unavailable during the read")on mid-read snapshot disappearance soexplore_results_api.pymaps it to HTTP 409 while missing scopes stay 404.loopx/self_update.py,loopx/capabilities/native_chat/github_pr_evidence.py,loopx/cli_commands/support_control_upgrade.py,loopx/control_plane/coordination/remote_authority_gateway.py,loopx/extensions/lark/cli_resolution.py: explicitly pinencoding="utf-8"onos.fdopenand text-modesubprocesscalls.Test Alignment & Contention Stability (
16files)activation_state = "stopped"fixtures tobuild_goal_activation(...)/loopx_goal_activation_v1intests/extensions/test_periodic_report_goal_channel_delivery.py,tests/test_chat_operation_actions.py,tests/test_manager_context_handoff.py, andtests/test_zcode_goal_bridge.py.tests/presentation/test_background_services_api.py: initialize an emptyregistry.jsonin thehostfixture expected byroundtrip.drain().tests/test_chat_status_owner.py: importgoal_read_runtime_rootfrom canonicalloopx.chat.todo_source.tests/test_kunluncode_goal_mode.py: includesettlement_progress(schema_version="quota_settlement_progress_v0",state="settled",next_step=None,quota_spend_source="heartbeat") in mockcapture()payloads.tests/test_lark_native_reply_context.py: expect the single current-message lossless envelope GET while keeping zero parent/history reads and 1+messages-mget.tests/test_native_steward_turn_host.py: monkeypatchCodexAppServerAdapter.start_native_task_turnfor themanaged_turnexecution path.tests/test_task_lease_worktree.py: prepend the active environment binary directory toPATHso subprocessloopxinvocations match the checked-out CLI.tests/test_turn_machine_credential.py: include"LOOPX_TURN_KEY"in expected turn environment verification.tests/test_global_todo_readiness_characterization.py: updateBASE_REVISIONtod210e4cc1d002f92498b2811c565b9430e79f4c1while keeping alltest_complete_outputs_and_crossingsgolden fixture assertions unchanged.GIT_PROBE_TIMEOUT_SECONDSto1.5intests/test_contract_git_probe_budget.py,tests/test_doctor_git_probe_budget.py, andtests/test_lark_event_collector_git_budget.py, and raise thread-event wait/join timeouts (8s->15s) intests/test_lark_private_ingress.py(test_shared_listener_drains_group_inbox_when_private_workspace_changes).Verification
pytestacross 24 targeted & adjacent regression test files:627 passed(1066.53s)ruff checkon all 23 changed files:All checks passed!mypy(pyproject.toml):Success: no issues found in 17 source filesscripts/check_rfc_bilingual.py --base origin/main --head HEAD:RFC bilingual diff check passed.loopx check --scan-pathon all 23 changed files:ok: true,0errors (public boundary scan clean: 23 files)loopx canary premerge --from-git-diff --git-diff-base origin/main --goal-id personal-loopx-maintenance:status="passed",merge_gate_passed=true(direct_checks:4/4,python_compile:1/1,catalog_canaries:10/10,risk_profile_smokes:8/8)cqr_cd5f2f4bbcce0ba2fa8c(status="valid",decision="pass",receipt_valid=true,scope_fingerprint="cd5f2f4bbcce0ba2fa8c366830be9658c0c3af05413a4d1234998c524b0be25e")